Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Shift-Mod-C for copying the markdown source #3941

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Mar 14, 2023

Signed-off-by: Julius Härtl jus@bitgrid.net

📝 Summary

See title, should make our lives easier when copying stuff to other areas that need markdown.

Note this only works in a secure browser context (when using HTTPS)

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@cypress
Copy link

cypress bot commented Mar 14, 2023

1 flaky tests on run #9047 ↗︎

0 136 1 0 Flakiness 1

Details:

feat: Add Shift-Mod-C for copying the markdown source
Project: Text Commit: 3d08ba2bc7
Status: Passed Duration: 04:02 💡
Started: Mar 14, 2023 1:16 PM Ended: Mar 14, 2023 1:20 PM
Flakiness  cypress/e2e/share.spec.js • 1 flaky test

View Output Video

Test Artifacts
Open test.md in viewer > Share a file with download disabled shows an error Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, works like expected 🎉

@juliushaertl
Copy link
Member Author

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@juliushaertl juliushaertl merged commit 7741ade into main Mar 14, 2023
@juliushaertl juliushaertl deleted the enh/copy-markdown branch March 14, 2023 15:16
@juliushaertl
Copy link
Member Author

/backport to stable26

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin/stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@mejo-
Copy link
Member

mejo- commented Mar 14, 2023

/backport 3aab433 to stable26

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin/stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@mejo-
Copy link
Member

mejo- commented Mar 14, 2023

/backport 3aab433 to stable26

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

@mejo-
Copy link
Member

mejo- commented Mar 14, 2023

Manual backport to stable26: #3942

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review backported successfully backported enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants