Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable27] fix: handle non markdown files in conflicts #4272

Merged
merged 5 commits into from
Aug 17, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

Backport of #4220

@cypress
Copy link

cypress bot commented Jun 8, 2023

6 failed and 1 flaky tests on run #11700 ↗︎

6 142 2 0 Flakiness 1

Details:

[stable27] fix: handle non markdown files in conflicts
Project: Text Commit: 0895c853a3
Status: Failed Duration: 05:48 💡
Started: Aug 17, 2023 7:00 AM Ended: Aug 17, 2023 7:06 AM
Failed  workspace.spec.js • 1 failed test

View Output Video

Test Artifacts
Workspace > relative folder links Output Screenshots
Failed  nodes/Links.spec.js • 3 failed tests

View Output Video

Test Artifacts
... > without text Output Screenshots
... > with selected text Output Screenshots
... > link to directory Output Screenshots
Failed  attachments.spec.js • 2 failed tests

View Output Video

Test Artifacts
Test all attachment insertion methods > Insert an image file from Files Output Screenshots
Test all attachment insertion methods > test if attachment files are in the attachment folder Output Screenshots
Flakiness  cypress/e2e/api/SyncServiceProvider.spec.js • 1 flaky test

View Output Video

Test Artifacts
Sync service provider > recovers from a dropped message Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@mejo-
Copy link
Member

mejo- commented Jun 19, 2023

@juliushaertl juliushaertl added bug Something isn't working 25 feedback labels Jun 19, 2023
@juliushaertl

This comment was marked as outdated.

@juliushaertl
Copy link
Member

Hm, not sure what goes wrong there yet, also test seem fine on stable26 and main

@blizzz
Copy link
Member

blizzz commented Aug 2, 2023

I think cypress is running with compiled assets.

@blizzz
Copy link
Member

blizzz commented Aug 3, 2023

moving to 27.1.0

@skjnldsv skjnldsv mentioned this pull request Aug 8, 2023
2 tasks
@skjnldsv
Copy link
Member

➡️ For beta 2

@skjnldsv skjnldsv mentioned this pull request Aug 16, 2023
7 tasks
@skjnldsv
Copy link
Member

Please merge or update milestone to 27.1.1

Do not parse non markdown files when resetting the content.

Fixes #4205.

Signed-off-by: Max <max@nextcloud.com>
Both the `.text-editor__main` and the `#read-only-editor`
are not part of the Editor component that the style is scoped for.

Signed-off-by: Max <max@nextcloud.com>
Text files are rendered as code blocks.
Do not apply the prosemirror style to keep the background color.

Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud
Copy link
Collaborator

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@max-nextcloud
Copy link
Collaborator

Same tests are failing on the main branch. They are due to changes in the file picker.

@max-nextcloud max-nextcloud merged commit c0440c2 into stable27 Aug 17, 2023
28 of 32 checks passed
@max-nextcloud max-nextcloud deleted the backport/4220/stable27 branch August 17, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing 25 feedback bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants