fix(frontend): Improve paste handler for table cells #4452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejo-
force-pushed
the
fix/paste_formatting
branch
from
09db13b
to
32a9593
Compare
1 flaky tests on run #10912 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| test link marks > autolink > without protocol |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
luka-nextcloud
approved these changes
Jul 7, 2023
juliushaertl
approved these changes
Jul 10, 2023
This replaces the broken approach from #3906. * Only regard paste handler if pasting to a table cell (Fixes: #4443) * Add all (marked) text nodes with newlines in between * Only add a newline for non-text nodes to prevent newlines in between text with changing marks. Signed-off-by: Jonas <jonas@freesources.org>
juliushaertl
force-pushed
the
fix/paste_formatting
branch
from
32a9593
to
02f8f91
Compare
|
/compile |
|
/backport 02f8f91 to stable27 |
|
/backport 02f8f91 to stable26 |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This was referenced Jul 10, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the broken approach from #3906.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)