-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix migration from v-tooltip
to native title
in menu bar buttons ActionEntry
#5233
Fix migration from v-tooltip
to native title
in menu bar buttons ActionEntry
#5233
Conversation
4a707d0
to
7292555
Compare
This comment was marked as outdated.
This comment was marked as outdated.
7292555
to
129456d
Compare
No need for comiting compiled assets here, for text we automated this after the merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for that ❤️
129456d
to
9cfed18
Compare
This seems to be a regression of #5174 So should also be backported |
/backport to stable28 |
- Remove usage of already deleted directive v-tooltip - Fixed native title text to be the same as was used in tooltip to show shortcuts on desktop Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
9cfed18
to
0780eab
Compare
2 commits just squashed into one as they both actually fix migrating from No changes in the code. |
v-tooltip
to native title
in menu bar buttons ActionEntry
0780eab
to
592252e
Compare
It is already added to prototype. Having properties (e.g. computed) for this method in instances throws exception: > The computed property "t" is already defined as a method. Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
592252e
to
82ddbac
Compare
Removing Returned it 🙈 |
📝 Summary
Migration from
v-tooltip
to nativetitle
was not complete in<ActionSingle>
title
onNcAction
title
text🖼️ Screenshots
Duplication of
t
definitionIn some components translation method
t
was added as a computed propertyt: () => window.t
or a method. But methodt
is already added globally by prototype monkey-patching:Vue.prototype.t = t
.It caused error. Removed as not needed.
🏁 Checklist
npm run lint
/npm run stylelint
/composer run cs:check
)