Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): use output rather than failure #5380

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Conversation

max-nextcloud
Copy link
Collaborator

@max-nextcloud max-nextcloud commented Feb 12, 2024

πŸ“ Summary

  • Resolves: build jobs from being marked as canceled and reduces notificiation noise.

πŸ–ΌοΈ Screenshots

(note that the error is gone)

🏚️ Before 🏑 After - no changes βœ… 🏑 After - with changes πŸ—οΈ
grafik grafik grafik

🚧 TODO

  • test with a diff
  • test without a diff

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Testing in this PR... hope it will just work afterwards.
  • Documentation is not required

@max-nextcloud

This comment was marked as resolved.

@max-nextcloud max-nextcloud marked this pull request as draft February 12, 2024 10:18
@juliushaertl

This comment was marked as resolved.

@max-nextcloud
Copy link
Collaborator Author

Could you try to push again? I've added the branch to the allow list for now

Yes... works now. Thanks!

Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud max-nextcloud merged commit 470fc70 into main Feb 12, 2024
62 checks passed
@max-nextcloud max-nextcloud deleted the ci/update-node-dist branch February 12, 2024 21:02
@max-nextcloud
Copy link
Collaborator Author

/backport to stable28

Copy link

backportbot bot commented Feb 12, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/5380/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 0feb769d

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5380/stable28

Error: Failed to push branch backport/5380/stable28: To https://github.com/nextcloud/text.git
! [remote rejected] backport/5380/stable28 -> backport/5380/stable28 (refusing to allow a GitHub App to create or update workflow .github/workflows/update-node-dist.yml without workflows permission)
error: failed to push some refs to 'https://github.com/nextcloud/text.git'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants