Use vitest instead of jest #5821
Merged
+4,169
−9,710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-nextcloud
force-pushed
the
enh/vitest
branch
4 times, most recently
from
69b86e5
to
f3176b2
Compare
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Typescript provides type checks for the arguments. No need for an object with named args. Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
vite.config.ts also defines the vitest config. Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
* need to inline `@nextcloud/dialogs` so `@nextcloud/vue` is always inlined. * specify setup file in vite config. * add types for window.t and window.n * get `t` from window.t in Menu/keys.js Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
* Port changed to 3000. * Stub axios request as `vitest` will catch failing requests even if the test itself passes. Signed-off-by: Max <max@nextcloud.com>
Also move mocks from setup.mjs into testHelpers. Signed-off-by: Max <max@nextcloud.com>
`createCustomEditor.ts` test script imports `Paragraph` and `tsc` complains without type definitions. Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
enh/vitest
branch
from
f3176b2
to
bdd20d6
Compare
max-nextcloud
requested review from
juliushaertl
and removed request for
mejo-
Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
added
3. to review
dependencies
juliushaertl
approved these changes
Oct 14, 2024
Signed-off-by: Max <max@nextcloud.com>
juliushaertl
force-pushed
the
enh/vitest
branch
from
e8d4ab5
to
44efc04
Compare
|
Not sure why cypress tests didn't run, pushed again to double check |
|
https://github.com/nextcloud/text/actions/runs/11323139310/job/31496900473 I think cypress actually ran. Maybe just been stuck on the queue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)