Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow viewing of attachments when shared by mail #6282

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Allow viewing of attachments when shared by mail #6282

merged 2 commits into from
Aug 29, 2024

Conversation

ksoeren
Copy link
Contributor

@ksoeren ksoeren commented Aug 29, 2024

📝 Summary

Attachments in text files shared by mail can now be viewed and no longer return an error.

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

@ksoeren
Allow viewing of attachments when shared by mail
38c3784 
Signed-off-by: soeren.kaschubowski <soeren.kaschubowski@hetzner.com>
@ksoeren
Spaces -> Tabs
0784b3b 
Signed-off-by: soeren.kaschubowski <soeren.kaschubowski@hetzner.com>
@ksoeren ksoeren mentioned this pull request Aug 29, 2024
Closed
@juliushaertl juliushaertl added bug Something isn't working 3. to review labels Aug 29, 2024
@juliushaertl juliushaertl added this to the Nextcloud 31 milestone Aug 29, 2024
@juliushaertl
Copy link
Member

Great, thanks a lot for your contribution 👍

@juliushaertl juliushaertl merged commit 58836e7 into nextcloud:main Aug 29, 2024
61 of 63 checks passed
@juliushaertl
Copy link
Member

/backport to stable30

@juliushaertl
Copy link
Member

/backport to stable29

@juliushaertl
Copy link
Member

/backport to stable28

@backportbot backportbot bot mentioned this pull request Aug 29, 2024
Merged
This was referenced Aug 29, 2024
Merged
Merged
@github-actions GitHub Actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

Assignees
No one assigned
Labels
3. to review bug Something isn't working feedback-requested
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.

Attachments do not load for markdown files shared via mail
2 participants
@ksoeren @juliushaertl