-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix headings papercuts #6404
Merged
Merged
Fix headings papercuts #6404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't look nice with open sidebar. Signed-off-by: Jonas <jonas@freesources.org>
Better visual separation of menubar and editor content, especially when scrolling long content. Signed-off-by: Jonas <jonas@freesources.org>
mejo-
added
bug
Something isn't working
3. to review
bug: regression
design: papercut
labels
Sep 15, 2024
/backport to stable30 |
This was referenced Sep 15, 2024
jancborchardt
approved these changes
Sep 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice! Thanks for the feedback as well @bentuna!
jancborchardt
approved these changes
Sep 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice! Thanks for the feedback as well @bentuna!
mejo-
force-pushed
the
fix/headings_papercuts
branch
from
September 15, 2024 15:48
7441a0a
to
90696a2
Compare
max-nextcloud
approved these changes
Sep 15, 2024
susnux
approved these changes
Sep 15, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Quick fixes from design feedback during conference:
🖼️ Screenshots
🏁 Checklist
npm run lint
/npm run stylelint
/composer run cs:check
)