Use new dispatcher for password policy event #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
|
Just to be clear: the old code can be used at least until version 19. And this code will work from 18 onwards. So there is some overlap. If you are willed to let the existing version being the last one for 17 and move forward then merging this and release it is okay. |
|
This would be the removal: nextcloud/password_policy@2ca03a6 |
ChristophWurst
approved these changes
Jul 10, 2020
mlojewski-me
approved these changes
Jul 12, 2020
delete-merged-branch
bot
deleted the
feature/noid/use-new-dispatcher-for-password_policy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to nextcloud/server#18019 and allows to drop the old ones in the password policy app. It works from 18 onwards thus I raised the version in the info.xml. Currently the oldest supported version is 17.
That would help us move forward the password policy app. We would like to remove that with one of the coming Nextcloud releases (best would be 20).