Implement dark/light/default theme for viewer handlers #1051
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to nextcloud/text#82
This PR adds the capability for mimetype handlers to indicate in which theme mode they run for their file displaying. The following 3 modes would be available:
light
viewer theme)The only thing I'm not entirely happy is that the theme is only available once the viewer has fetched the fileinfo (which might take a bit depending on the network and server). In order to avoid flickering between dark/light, I for now introduced an intermediate loading state where there is no mask background and just the loading spinner until the theme is available. (See screen recordings for how that looks) Though I'm of course open for other ideas how to handle that.
Peek.2021-10-15.09-44.mp4
Peek.2021-10-15.09-44-dark.mp4