-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: how to open a shared file #1241
Conversation
Hey @max-nextcloud , can you give me context on why you need to document that? |
I ran into this twice recently. Once when opening linked files in the collectives app. Collectives can now be shared via links. Under the hood this results in sharing the collective folder. So we have a share token that we provide for The other occasion was when working on #995 with @vanpertsch. We ran into PROPFIND 404s when trying to open shared files. This time it turned out the I'm happy to document this elsewhere - maybe it already is and i just did not read those docs yet. What do you think would be the best place to document this? |
I think this is more a bad API design than a need for documentation then :) Second thing, is actually this: nextcloud/server#19700 |
A collective share renders an empty div in the template and then loads the collectives vue app in there. So in terms of rendering it's a completely different approach from what the The functionality in collectives that relies on the viewer API is opening a linked file such as a pdf on top of the collective.
Collectives provides the token as part of rendering the markdown view: https://gitlab.com/collectivecloud/collectives/-/blob/main/src/components/Page/RichText.vue#L3 Lines 38 to 40 in ff759ac
|
This comment was marked as resolved.
This comment was marked as resolved.
Document how to provide `sharingToken` in an app so shared files can be opened. Signed-off-by: Max <max@nextcloud.com>
6849dd7
to
984491c
Compare
Document how to provide
sharingToken
in an app so shared files can be opened.Signed-off-by: Max max@nextcloud.com