Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Viewer.vue #1783

Closed
wants to merge 3 commits into from
Closed

Conversation

pushyajn01
Copy link

fixes #1579
Swapped the verification of handler variable before using it for theme

use of handler variable swapped with its verification

Signed-off-by: Pushyajain <87334227+Pushyajain@users.noreply.github.com>
@skjnldsv
Copy link
Member

skjnldsv commented Jul 7, 2023

/backport to stable27

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Jul 7, 2023
@skjnldsv
Copy link
Member

skjnldsv commented Jul 7, 2023

/backport to stable26

@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews labels Jul 7, 2023
@skjnldsv
Copy link
Member

skjnldsv commented Jul 7, 2023

Can you please fix eslint as well as the commit message by using something more relevant?
Like fix: handler theme variable assignment

@pushyajn01
Copy link
Author

Can you please fix eslint as well as the commit message by using something more relevant? Like fix: handler theme variable assignment

Yeah Sure ! I will do that

@szaimen szaimen added this to the Nextcloud 28 milestone Jul 10, 2023
@skjnldsv
Copy link
Member

@pushyajn01 ping 🤗

@pushyajn01
Copy link
Author

Hey there! 😊

@skjnldsv
Copy link
Member

skjnldsv commented Aug 15, 2023

Can you please fix eslint as well as the commit message by using something more relevant? Like fix: handler theme variable assignment

@pushyajn01 pushyajn01 closed this Aug 18, 2023
@pushyajn01 pushyajn01 deleted the file-view-UI-fix branch August 18, 2023 18:17
@skjnldsv skjnldsv removed the backport-request Pending backport by the backport-bot label Aug 18, 2023
@pushyajn01 pushyajn01 restored the file-view-UI-fix branch August 19, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening an unsupported mime file freezes the UI
3 participants