Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed wrong color on active actions button #2139

Merged

Conversation

emoral435
Copy link
Contributor

☑️ Resolves #2138

🖼️ Screenshots
firefox_QHrfv5gnmn

^This would previously caused the button to have the correct background-color!

🚧 Summary
When the button was focused, this caused the NcButton to have these styles applied : https://github.com/nextcloud-libraries/nextcloud-vue/blob/c39a05682403a19d5ba6e8699ca496e28daa4232/src/components/NcActions/NcActions.vue#L1669

Arguably, you could say that I should edit the components styles here - however, they where added for a reason, and changing that styling could cause regressions all around the server, so its best to change it personally within the viewers view!

Checklist

Code is properly formatted

Sign-off message is added to all commits

[ ] Tests (unit, integration, api and/or acceptance) are included

[x] Screenshots before/after for front-end changes

[x] Documentation (manuals or wiki) has been updated or is not required

[x] Backports requested where applicable (ex: critical bugfixes)

@emoral435 emoral435 added bug Something isn't working 3. to review Waiting for reviews accessibility labels Jan 30, 2024
@emoral435 emoral435 added this to the Nextcloud 29 milestone Jan 30, 2024
@emoral435 emoral435 self-assigned this Jan 30, 2024
@emoral435
Copy link
Contributor Author

/backport to stable28

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Jan 30, 2024
@emoral435
Copy link
Contributor Author

/compile amend/

src/views/Viewer.vue Outdated Show resolved Hide resolved
@emoral435 emoral435 force-pushed the fix/a11y/2138/wrong-color-on-active-actions-buttons branch from 66f6d22 to 31164ca Compare January 30, 2024 13:11
@emoral435
Copy link
Contributor Author

Moved the changed CSS to another appropriate place that lets it not display the outline 👍

@emoral435 emoral435 requested a review from Pytal January 30, 2024 13:13
src/views/Viewer.vue Outdated Show resolved Hide resolved
@emoral435 emoral435 force-pushed the fix/a11y/2138/wrong-color-on-active-actions-buttons branch 2 times, most recently from 50799ae to 3ac8bea Compare January 30, 2024 19:39
@emoral435 emoral435 requested a review from Pytal January 30, 2024 19:53
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
@Pytal Pytal force-pushed the fix/a11y/2138/wrong-color-on-active-actions-buttons branch from 3ac8bea to c820b3d Compare January 30, 2024 21:49
@Pytal
Copy link
Member

Pytal commented Jan 30, 2024

Thanks @emoral435! Force-pushed a small adjustment to remove !important so the hover/focus styles apply correctly

@Pytal
Copy link
Member

Pytal commented Jan 30, 2024

/compile amend /

Signed-off-by: Eduardo Morales <emoral435@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the fix/a11y/2138/wrong-color-on-active-actions-buttons branch from c820b3d to d4166c1 Compare January 30, 2024 21:56
@emoral435
Copy link
Contributor Author

Thank you @Pytal :)

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 1, 2024
@emoral435

This comment was marked as resolved.

@JuliaKirschenheuter
Copy link
Contributor

/backport f75d877 to stable28

@AndyScherzinger AndyScherzinger merged commit b31e3d1 into master Feb 5, 2024
27 of 29 checks passed
@AndyScherzinger AndyScherzinger deleted the fix/a11y/2138/wrong-color-on-active-actions-buttons branch February 5, 2024 10:36
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Feb 5, 2024
Copy link

github-actions bot commented May 3, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility bug Something isn't working feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BITV]: wrong color on active actions button
6 participants