Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Enforce unsetting openfile when the viewer is closed #2368

Merged
merged 2 commits into from
Jul 16, 2024
Merged

fix: Enforce unsetting openfile when the viewer is closed #2368

merged 2 commits into from
Jul 16, 2024

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Jul 15, 2024 •
edited
Loading

Can occure when the view is loaded with the openfile set already. Or when creating a file.

@artonge
fix: Enforce unsetting openfile when the viewer is closed
2923900 
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
artonge commented Jul 15, 2024
View reviewed changes
Copy link
Contributor Author

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport to stable29

artonge
artonge commented Jul 15, 2024
View reviewed changes
Copy link
Contributor Author

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport to stable29

@artonge artonge self-assigned this Jul 15, 2024
artonge
artonge commented Jul 15, 2024
View reviewed changes
Copy link
Contributor Author

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport to stable28

@artonge artonge requested review from skjnldsv and susnux July 15, 2024 09:55
@artonge artonge added bug Something isn't working 3. to review Waiting for reviews javascript Javascript related ticket labels Jul 15, 2024
@artonge artonge added this to the Nextcloud 30 milestone Jul 15, 2024
@artonge
chore: Compile assets
3601f1d 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge merged commit db54356 into master Jul 16, 2024
28 checks passed
@artonge artonge deleted the artonge/fix/enforce_unsetting_openfile branch July 16, 2024 10:27
@artonge
Copy link
Contributor Author

artonge commented Jul 17, 2024

/backport to stable29

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Jul 17, 2024
@artonge

This comment was marked as outdated.

Sign in to view
@backportbot backportbot bot mentioned this pull request Jul 17, 2024
Merged
2 tasks
@artonge

This comment was marked as outdated.

Sign in to view
@backportbot backportbot bot added backport-request Pending backport by the backport-bot and removed backport-request Pending backport by the backport-bot labels Jul 17, 2024
@artonge
Copy link
Contributor Author

artonge commented Jul 17, 2024

/backport 2923900 to stable28

@backportbot backportbot bot mentioned this pull request Jul 17, 2024
Merged
2 tasks
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Jul 17, 2024
@backportbot backportbot

This comment was marked as resolved.

Sign in to view
@backportbot backportbot

This comment was marked as resolved.

Sign in to view
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
@skjnldsv skjnldsv mentioned this pull request Jul 26, 2024
Closed
8 tasks
@susnux susnux mentioned this pull request Jul 27, 2024
Closed
8 tasks
@sunetfreitag sunetfreitag mentioned this pull request Aug 30, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@artonge artonge

Labels
3. to review Waiting for reviews bug Something isn't working javascript Javascript related ticket
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.

[Bug]: Fail to create a second file in the Files web interface, unless I reload
2 participants
@artonge @susnux