feat: Whiteboard collaboration #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
hweihwang
force-pushed
the
feat/collab
branch
6 times, most recently
from
6dc1d4e
to
706147e
Compare
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
move helper functions to util.ts Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
hweihwang
force-pushed
the
feat/collab
branch
3 times, most recently
from
5a4d5e3
to
02bb523
Compare
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
This was
linked to
issues
May 31, 2024
Closed
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
1 task
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
|
Next steps as discussed with @hweihwang
|
juliushaertl
approved these changes
Jun 6, 2024
|
@juliushaertl I have not been part of that discussion so there are surely reasons to do it that way. But I am wondering why we have to implement a new auth method for the node server. I though the node server would be gone soon as we initially planned to re-implement the web socket in php and could therefore use the nextcloud user-auth already. Are we going to keep the seperate node server? |
This was referenced Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7