Skip to content

Commit

Permalink
[nextest-runner] explain why partition-based filtering must be at the…
Browse files Browse the repository at this point in the history
… end

As @Guiguiprim pointed out in #159, partition-based filtering must
happen after all other kinds.
  • Loading branch information
sunshowers committed Apr 18, 2022
1 parent 95e2f29 commit c047716
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions nextest-runner/src/test_filter.rs
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,9 @@ impl<'filter> TestFilter<'filter> {
self.filter_ignored_mismatch(ignored)
.or_else(|| self.filter_name_mismatch(test_name))
.or_else(|| self.filter_expression_mismatch(test_binary, test_name))
// Note that partition-based filtering MUST come after all other kinds of filtering,
// so that count-based bucketing applies after ignored, name and expression matching.
// This also means that mutable count state must be maintained by the partitioner.
.or_else(|| self.filter_partition_mismatch(test_name))
.unwrap_or(FilterMatch::Matches)
}
Expand Down

0 comments on commit c047716

Please sign in to comment.