Fix hashing on windows #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running the most recent commit in this PR locally results in a |
mk
force-pushed
the
fix-hashing-on-windows
branch
from
bf18498
to
478d027
Compare
|
@respatialized if you can, I'd appreciate if you could try this once more, using the latest sha on this PR as a git dependency and confirm that (= "3mXdcLQSNAEFTLdDXoAw47rKytXS"
((requiring-resolve 'nextjournal.clerk.render.hashing/front-end-hash)))
;;=> true |
|
@mk Yes, I am able to load |
This reverts commit d0e1333.
mk
force-pushed
the
fix-hashing-on-windows
branch
from
6081edd
to
835e001
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the
nextjournal.clerk.render.hashing/front-end-hashcomputation that would previously fail on windows. Also set.gitattributesto get the same line endings on windows so the hash is stable on different platforms.