Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize pathogen-repo-ci use across pathogen repos #84

Closed
6 tasks done
joverlee521 opened this issue May 15, 2024 · 3 comments
Closed
6 tasks done

Standardize pathogen-repo-ci use across pathogen repos #84

joverlee521 opened this issue May 15, 2024 · 3 comments
Assignees

Comments

@joverlee521
Copy link
Contributor

joverlee521 commented May 15, 2024

Ideas here came out of discussion with @tsibley in our 1:1 regarding #62 (comment). This would supersede #63 + #62.

Proposal

With the standardization of pathogen repos following the pathogen-repo-guide, we can now enforce the standardized use of the pathogen-repo-ci workflow.

In order to use the centralized pathogen-repo-ci, a pathogen repo will need to meet two requirements.

  1. follow a strict repo organization (currently required to have a phylogenetic subdirectory)

  2. use a standard mechanism for specifying the CI build, e.g. use a standard CI config that can be specified with

    nextstrain build phylogenetic --configfiles build-configs/ci/config.yaml
    

This would simplify each pathogen repo's CI workflow to:

name: CI

on:
  - push
  - pull_request

jobs:
  ci:
    uses: nextstrain/.github/.github/workflows/pathogen-repo-ci.yaml@master

Then the docker-base/conda-base CIs can be simplified to just matrix of pathogen repos instead of needing to pass in additional build args.

Concrete steps

@victorlin
Copy link
Member

I'm a bit out of the loop here. What's the difference between mpox's CI (which uses pathogen-repo-build) and avian-flu's CI (which uses pathogen-repo-ci)? Can avian-flu use pathogen-repo-build? Or is mpox's use of pathogen-repo-build considered temporary and will be replaced during the 3rd task here?

@joverlee521
Copy link
Contributor Author

Or is mpox's use of pathogen-repo-build considered temporary and will be replaced during the 3rd task here?

Yup, the use of the pathogen-repo-build in CI is considered a temporary change (if ~6 months is considered temporary 😅). The plan would be to switch all pathogen GitHub Action CI workflows back to pathogen-repo-ci.

@genehack
Copy link
Contributor

Related/precursor work: #89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants