CI: Update pathogen-repo-ci #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Add comments to clearly show the job `pathogen-repo-ci-v0` is for pathogen repos that do not conform to the standard pathogen repo structure. Since these are tied to an old structure of pathogen repos, the job should not be expected to be updated. Any new pathogen repos should be added to the `pathogen-repo-ci` job which replicates the centralized `pathogen-repo-ci` GH workflow. Replicating the centralized `pathogen-repo-ci` because we've made the decision to _not_ support ambient Augur version¹ ¹ <nextstrain/.github#66>
genehack
reviewed
Jul 18, 2024
As per @victorlin 's recommendation in related change in conda-base,¹ these pathogens can get updated as post-merge tasks for eventual PRs. ¹ <nextstrain/conda-base#85 (comment)>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1549 +/- ##
==========================================
+ Coverage 70.09% 70.13% +0.03%
==========================================
Files 74 74
Lines 7922 7922
Branches 1938 1938
==========================================
+ Hits 5553 5556 +3
+ Misses 2085 2081 -4
- Partials 284 285 +1 ☔ View full report in Codecov by Sentry. |
victorlin
approved these changes
Jul 22, 2024
Move the latest pathogen-repo-ci above legacy version as per @genehack's recommendation in review <#1549 (review)>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Add comments to clearly show the job
pathogen-repo-ci-v0is for pathogen repos that do not conform to the standard pathogen repo structure. Since these are tied to an old structure of pathogen repos, the job should not be expected to be updated.Any new pathogen repos should be added to the
pathogen-repo-cijob which replicates the centralizedpathogen-repo-ciGH workflow. Replicating the centralizedpathogen-repo-cibecause we've made the decision to not support ambient Augur version¹¹ nextstrain/.github#66
Related issue(s)
Related to nextstrain/.github#84
Checklist