Skip to content

Commit

Permalink
Merge pull request #1571: Simplify Python version config for mypy/pyr…
Browse files Browse the repository at this point in the history
…ight
  • Loading branch information
victorlin authored Aug 8, 2024
2 parents dbc9d4c + 3bb8c95 commit 66e903a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
6 changes: 0 additions & 6 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,6 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/setup-python@v5
with:
# Types must be written for the lowest compatible Python version
python-version: '3.8'
- uses: actions/checkout@v4
- run: pip install .[dev]
- run: mypy
Expand All @@ -29,9 +26,6 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/setup-python@v5
with:
# Sync this with pythonVersion in pyrightconfig.json
python-version: '3.8'
- uses: actions/checkout@v4
- run: npx pyright --stats

Expand Down
3 changes: 3 additions & 0 deletions mypy.ini
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
[mypy]
# Check against lowest compatible Python version
python_version = 3.8

# Don't set python_version. Instead, use the default behavior of checking for
# compatibility against the version of Python used to run mypy.
files = augur/
Expand Down

0 comments on commit 66e903a

Please sign in to comment.