Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow selection of metadata ID column #1237

Closed
jameshadfield opened this issue Jun 8, 2023 · 2 comments · Fixed by #1240
Closed

Allow selection of metadata ID column #1237

jameshadfield opened this issue Jun 8, 2023 · 2 comments · Fixed by #1240
Assignees
Labels
enhancement New feature or request

Comments

@jameshadfield
Copy link
Member

jameshadfield commented Jun 8, 2023

A number of augur commands perform linkage between input sequences (FASTA, sometimes VCF) and metadata via a column in the metadata.

The default columns are (only the first found column will be used):

DEFAULT_ID_COLUMNS = ("strain", "name")

Augur filter has the ability to modify this, but other augur commands do not:

input_group.add_argument('--metadata-id-columns', default=DEFAULT_ID_COLUMNS, nargs="+", help="names of possible metadata columns containing identifier information, ordered by priority. Only one ID column will be inferred.")

We should add this ability to all applicable augur commands - export v2, refine, frequencies. There may be others? We don't need to add it to export v1.

This will allow us to simplify workflows such as monkeypox, dengue and RSV which use accession as the sequence identifier.

@victorlin
Copy link
Member

@jameshadfield: This will allow us to simplify workflows such as monkeypox, dengue and RSV which use accession as the sequence identifier.

I created PRs for monkeypox and RSV. I don't see any references in dengue, so no PR there.

@jameshadfield
Copy link
Member Author

I created PRs for monkeypox and RSV. I don't see any references in dengue, so no PR there.

Thanks! The dengue work is happening on a branch so I'll let @j23414 update that as desired 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants