Allow selection of metadata ID column #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since it is not a positional argument.
Previously, this flag to customize the default value was only available in augur filter. Add it to other subcommands to parallel the existing support for --metadata-valid-delimiters which serves a similar purpose.
victorlin
commented
Jun 14, 2023
There was a problem hiding this comment.
Re: @jameshadfield in original issue description:
We don't need to add it to
export v1.
I opted to add this to export v1 to keep things consistent, plus it's an easy change.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1240 +/- ##
==========================================
+ Coverage 68.88% 68.90% +0.02%
==========================================
Files 64 64
Lines 6939 6944 +5
Branches 1693 1693
==========================================
+ Hits 4780 4785 +5
Misses 1854 1854
Partials 305 305
☔ View full report in Codecov by Sentry. |
joverlee521
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
See commit messages.
Related issue(s)
Resolves #1237.
Testing
No tests added.
Checklist