Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

augur curate parse-genbank-location: Remove database check #1511

Closed
joverlee521 opened this issue Jul 2, 2024 · 0 comments
Closed

augur curate parse-genbank-location: Remove database check #1511

joverlee521 opened this issue Jul 2, 2024 · 0 comments
Assignees
@genehack

Comments

@joverlee521
Copy link
Contributor

Originally discussed in #1508 (comment).

As @genehack commented:

Seems to me like duck-typing on the field you're operating on is a better check than keying off a second field
@joverlee521 joverlee521 mentioned this issue Jul 2, 2024
Merged
2 tasks
@genehack genehack self-assigned this Jul 2, 2024
genehack added a commit that referenced this issue Jul 2, 2024
@genehack
Remove the requirement for a database field [#1511]
f1f05da 
Per discussion on #1508 and #1511, the field standardization across
records (cf #1510) makes the need to verify a `database` field less
important — essentially, if there's a `geo_loc_name` field (or a field
with the name given in the `--location-field` argument), parse it.
Otherwise, warn that it's not found.
@genehack genehack mentioned this issue Jul 2, 2024
Merged
2 tasks
genehack added a commit that referenced this issue Jul 2, 2024
@genehack
Merge pull request #1513 from nextstrain/no-db-for-gb-1511
c679fde 
Remove the requirement for a `database` field in `augur curate parse-genbank-location` [#1511]
@genehack genehack closed this as completed Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@genehack genehack

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@genehack @joverlee521