Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find iqtree executable #636

Closed
trvrb opened this issue Dec 14, 2020 · 3 comments · Fixed by #711
Closed

Find iqtree executable #636

trvrb opened this issue Dec 14, 2020 · 3 comments · Fixed by #711
Assignees
Labels
easy problem Requires less work than most issues enhancement New feature or request priority: moderate To be resolved after high priority issues

Comments

@trvrb
Copy link
Member

trvrb commented Dec 14, 2020

Context

IQ-TREE 2.1.2 offers some significance performance improvement specifically for SARS-CoV-2 (http://www.iqtree.org/). However, it slightly changes some of it's command line options and changes the name of the executable from iqtree to iqtree2.

Description

I'd like augur tree to use iqtree2 when it's available but to fall back to iqtree when it's not. This should offer an upgrade path to existing users. Currently, FastTree and RAxML use a find_executable function to determine which binary to call (https://github.com/nextstrain/augur/blob/master/augur/tree.py#L90, https://github.com/nextstrain/augur/blob/master/augur/tree.py#L40). We should just add a similar lookup to IQ-TREE.

@trvrb trvrb added the enhancement New feature or request label Dec 14, 2020
@trvrb trvrb added priority: moderate To be resolved after high priority issues easy problem Requires less work than most issues labels Jan 22, 2021
@trvrb
Copy link
Member Author

trvrb commented Jan 22, 2021

I just elevated this to "Product backlog" with the thought that providing iqtree2 to users will be a significant performance improvement for little effort. But it can easily be shifted back to "icebox" if desired.

@huddlej
Copy link
Contributor

huddlej commented Mar 30, 2021

IQ-TREE 2.1.2 is now in Bioconda, as of today. The Bioconda version renames the binary to iqtree, for backwards compatibility, and keeps the newer iqtree2 binary, too.

We should still implement the change proposed in this issue, though, for consistency across our tree builders.

@huddlej
Copy link
Contributor

huddlej commented Apr 2, 2021

@benjaminotter, can you add the call to find_executable that Trevor describes above for the build_iqtree function? This will work like the existing call for the build_raxml function.

You should be able to test that this function works by installing the latest IQ-TREE 2 release on your path as iqtree2 first and then also as iqtree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy problem Requires less work than most issues enhancement New feature or request priority: moderate To be resolved after high priority issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants