Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

augur tree: Adds call to find_executable for build_iqtree function #711

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

benjaminotter
Copy link
Contributor

Description of proposed changes

Adds the call of find_executable for the build_iqtree function to use the newer iqtree2 when available while still providing backwards compatibility with iqtree.

Related issue(s)

Fixes #636

Testing

@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #711 (31ad8fc) into master (24baeaf) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #711      +/-   ##
==========================================
- Coverage   31.31%   31.30%   -0.01%     
==========================================
  Files          41       41              
  Lines        5649     5650       +1     
  Branches     1365     1365              
==========================================
  Hits         1769     1769              
- Misses       3806     3807       +1     
  Partials       74       74              
Impacted Files Coverage Δ
augur/tree.py 9.13% <0.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24baeaf...31ad8fc. Read the comment docs.

@huddlej huddlej marked this pull request as ready for review April 7, 2021 17:50
Copy link
Contributor

@huddlej huddlej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked perfectly for me. Thanks, @benjaminotter!

@huddlej huddlej added this to the Next release milestone Apr 7, 2021
@huddlej huddlej merged commit 1815565 into master Apr 7, 2021
@huddlej huddlej deleted the iqtree-find-executable branch April 7, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find iqtree executable
2 participants