Report names of metadata duplicates in filter #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1008 +/- ##
===========================================
+ Coverage 0 59.68% +59.68%
===========================================
Files 0 53 +53
Lines 0 6320 +6320
Branches 0 1586 +1586
===========================================
+ Hits 0 3772 +3772
- Misses 0 2285 +2285
- Partials 0 263 +263 ☔ View full report in Codecov by Sentry. |
victorlin
approved these changes
Jul 27, 2022
Reports the names of duplicate strains as part of the error message when augur filter finds duplicates in the metadata, so the user knows where to start debugging their data.
huddlej
force-pushed
the
report-duplicate-metadata-in-filter
branch
from
8134299
to
7b48451
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Reports the names of duplicate strains as part of the error message when augur filter finds duplicates in the metadata, so the user knows where to start debugging their data.
Related issue(s)
Related to #918
Testing