Update PR template changelog checklist #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the language to reflect that entries in the changelog should only be end user focused changes. Motived by @tsibley's comment¹ in a recent PR. It's nice for external users if our changelog is not bloated by internal development changes! ¹ #1039 (comment)
|
I personally also think it's nice for external users if the changelog is not bloated by internal dev changes, but would like to hear other's opinions here! |
1 task
victorlin
approved these changes
Nov 7, 2022
tsibley
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating this PR for discussion around the idea that we should keep the changelog as end user focused changes only.
Motivated by @tsibley's recent comment: