Cram-ify "functional" pytests #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subsample-priority-values.t replaces two pytests (test_read_priority_scores_valid_with_spaces_and_tabs, test_read_priority_scores_valid) and covers a bit more. subsample-priority-file-error.t replaces two pytests (test_read_priority_scores_malformed, test_read_priority_scores_does_not_exist).
These are already covered by tests/functional/filter/cram/filter-query-example.t
Repurpose filter-min-date.t since it didn't check output contents.
The two tests are related, so put them in the same file.
Reorder imports, fix whitespace, and remove the unnecessary class
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1183 +/- ##
=======================================
Coverage 68.25% 68.25%
=======================================
Files 63 63
Lines 6772 6772
Branches 1659 1659
=======================================
Hits 4622 4622
Misses 1841 1841
Partials 309 309
... and 18 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
tsibley
approved these changes
Mar 20, 2023
See reasoning in changes.
victorlin
force-pushed
the
victorlin/update-filter-pytests
branch
from
579c7e3
to
d7785a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Note: the squashed changes are not review-friendly – see individual commit messages for a better experience.)
Description of proposed changes
Convert "functional" pytests that predated/overlooked the adoption of using Cram to write functional tests in this codebase (except for testing relative dates – see 579c7e3).
In terms of the logic being tested, I also removed some duplication and increased coverage in a few places.
Related issue(s)
N/A – this was prompted by work related to #854 where some of these tests are not compatible. Cram-ify-ing fixes that.
Testing
Checklist
Add a message in CHANGES.md summarizing the changes in this PR that are end user focused. Keep headers and formatting consistent with the rest of the file.N/A, no functional changes