Fix call to os.sched_getaffinity()
#1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts the changes from 1876886 on this file. When originally written, the assumption was a direct non-functional replacement. However, that wasn't the case: any errors from os.sched_getaffinity were no longer handled properly. The following commit will address the Mypy error (which is now present) in a way that does not change behavior.
An attempt at addressing the error was first attempted in 1876886 but reverted in the commit prior to this one. Adding an assert lets static type checkers know that function in the next line is available.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1251 +/- ##
==========================================
- Coverage 68.96% 68.94% -0.02%
==========================================
Files 64 64
Lines 6946 6948 +2
Branches 1696 1695 -1
==========================================
Hits 4790 4790
- Misses 1851 1853 +2
Partials 305 305
☔ View full report in Codecov by Sentry. |
tsibley
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This fixes an oversight from a recently merged PR.
Related issue(s)
Testing
Checklist
Add a message in CHANGES.md summarizing the changes in this PR that are end user focused. Keep headers and formatting consistent with the rest of the file.N/A, this is fixing a bug within the same release.