Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure output streams to support non-Unicode encodings #1290

Merged
merged 3 commits into from
Aug 24, 2023

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Aug 23, 2023

Description of proposed changes

Fixes a bug where Unicode characters in Augur's help output would result in an unhelpful error. This isn't expected to happen for most users. At the expense of those users, keep using Unicode characters; for them, print replacement characters.

Related issue(s)

Fixes #1272

Testing

  • PYTHONIOENCODING=latin-1 augur clades --help runs successfully with these changes.

Checklist

  • Add a message in CHANGES.md summarizing the changes in this PR that are end user focused. Keep headers and formatting consistent with the rest of the file.

Fixes a bug where Unicode characters in Augur's help output would result
in an unhelpful error. This isn't expected to happen for most users. At
the expense of those users, keep using Unicode characters; for them,
print replacement characters.
@victorlin victorlin requested a review from tsibley August 23, 2023 18:36
@victorlin victorlin self-assigned this Aug 23, 2023
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (b00afc1) 69.86% compared to head (fd85168) 69.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1290      +/-   ##
==========================================
+ Coverage   69.86%   69.87%   +0.01%     
==========================================
  Files          67       67              
  Lines        7155     7158       +3     
  Branches     1744     1744              
==========================================
+ Hits         4999     5002       +3     
  Misses       1849     1849              
  Partials      307      307              
Files Changed Coverage Δ
augur/__main__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

augur/__main__.py Outdated Show resolved Hide resolved
@victorlin victorlin merged commit 5b9ab8d into master Aug 24, 2023
27 checks passed
@victorlin victorlin deleted the victorlin/configure-output-streams branch August 24, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants