-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disable non-a-number filtering in clade file parsing #1293
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1293 +/- ##
=======================================
Coverage 69.92% 69.92%
=======================================
Files 67 67
Lines 7161 7162 +1
Branches 1745 1746 +1
=======================================
+ Hits 5007 5008 +1
Misses 1848 1848
Partials 306 306
☔ View full report in Codecov by Sentry. |
@victorlin do you think this can go in? The empty line handling is still bit wonky. But I think it is better than before... |
Co-authored-by: Richard Neher <richard.neher@unibas.ch>
Co-authored-by: Richard Neher <richard.neher@unibas.ch>
085c5ac
to
f5f9590
Compare
@rneher I force-pushed a new set of commits to make changes more clear, and added a changelog entry. Will merge after checks pass. |
11d414d
to
bf14933
Compare
Discovered as part of nextstrain/augur#1293 that the clade TSVs for this repo has excess whitespace which causes it to bypass the default `skip_blank_lines=True` behavior for `pandas.read_csv`. The issue has been fixed in Augur, but still nice to remove the excess whitespace here to keep things uniform with other pathogen clade TSVs. Note that the trailing whitespace after inherited clade definitions are required.
trival PR to allow gene names 'NA' in clades.tsv
Discussions