Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't support Biopython 1.82 #1374

Merged
merged 2 commits into from
Dec 22, 2023
Merged

Don't support Biopython 1.82 #1374

merged 2 commits into from
Dec 22, 2023

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Dec 22, 2023

Description of proposed changes

Biopython 1.82 was released a few hours ago¹ and has an undocumented breaking change in the SeqFeature API which is used indirectly in augur translate (through bcbio-gff).

It's possible that this should be a hard ceiling instead of a one-off exclusion, but make it the latter for now. Fixing compatibility requires upstream changes in bcbio-gff which is out of our control.

¹ https://github.com/biopython/biopython/blob/biopython-182/NEWS.rst

Related issue(s)

Checklist

  • Checks pass
  • If making user-facing changes, add a message in CHANGES.md summarizing the changes in this PR

Biopython 1.82 was released a few hours ago¹ and has an undocumented
breaking change in the SeqFeature API which is used indirectly in augur
translate (through bcbio-gff).

It's possible that this should be a hard ceiling instead of a one-off
exclusion, but make it the latter for now. Fixing compatibility requires
upstream changes in bcbio-gff which is out of our control.

¹ <https://github.com/biopython/biopython/blob/biopython-182/NEWS.rst>
@victorlin victorlin marked this pull request as ready for review December 22, 2023 23:18
@victorlin victorlin merged commit 00c0e9e into master Dec 22, 2023
21 of 22 checks passed
@victorlin victorlin deleted the victorlin/skip-biopython-182 branch December 22, 2023 23:18
@victorlin victorlin mentioned this pull request Dec 22, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant