filter: Replace backtick quoting in Pandas query #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorlin
force-pushed
the
victorlin/fix-backtick-quoting-by-replacement
branch
2 times, most recently
from
7b200da
to
a66ec16
Compare
victorlin
changed the base branch from
master
to
victorlin/restore-reading-all-columns
victorlin
force-pushed
the
victorlin/fix-backtick-quoting-by-replacement
branch
from
a66ec16
to
7247039
Compare
victorlin
force-pushed
the
victorlin/restore-reading-all-columns
branch
from
a207276
to
4e4f0d2
Compare
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1417 +/- ##
==========================================
+ Coverage 68.42% 68.50% +0.07%
==========================================
Files 69 69
Lines 7519 7537 +18
Branches 1843 1846 +3
==========================================
+ Hits 5145 5163 +18
Misses 2091 2091
Partials 283 283 ☔ View full report in Codecov by Sentry. |
tsibley
requested changes
Feb 16, 2024
Base automatically changed from
victorlin/restore-reading-all-columns
to
master
February 16, 2024 19:12
victorlin
force-pushed
the
victorlin/fix-backtick-quoting-by-replacement
branch
from
7247039
to
8d85ffb
Compare
ast.walk does not support the special case of backtick quoting that is supported by pandas.DataFrame.query, so it must be replaced for ast.walk then reversed to obtain the actual variable names.
victorlin
force-pushed
the
victorlin/fix-backtick-quoting-by-replacement
branch
from
8d85ffb
to
b4e3a27
Compare
tsibley
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
ast.walk does not support the special case of backtick quoting that is supported by pandas.DataFrame.query, so it must be replaced for ast.walk then reversed to obtain the actual variable names.
Related issue(s)
--querybroken with backtick quoting #1415Checklist