frequencies: Fix --regions flag
#1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the use of the `--regions` flag with values other than the default "global" region by: 1. including the "region" column from the metadata file, similar to how the weight attribute columns are included in dce0374. 2. annotating the tips with the "region" values from the metadata file, similar to how the weight attributes are annotated in dde857a.
joverlee521
force-pushed
the
fix-frequencies-region
branch
from
1cd2b20
to
20d9e21
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1424 +/- ##
==========================================
+ Coverage 68.50% 68.65% +0.14%
==========================================
Files 69 69
Lines 7537 7544 +7
Branches 1846 1849 +3
==========================================
+ Hits 5163 5179 +16
+ Misses 2091 2088 -3
+ Partials 283 277 -6 ☔ View full report in Codecov by Sentry. |
victorlin
approved these changes
Feb 23, 2024
The "region" column is only required when specifying regions that are not the default "global" region.
Update help text to reflect the use of the "region" column and values from the metadata file.
joverlee521
force-pushed
the
fix-frequencies-region
branch
from
20d9e21
to
455bcfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Follow up to #1294 and #1398
Fixes the error raised when using the
--regionsflag with values other than the default "global" region.See commits for details.
Related issue(s)
Resolves #1423
Checklist