Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port transform-field-names to augur curate rename #1506

Merged
merged 6 commits into from
Jul 9, 2024

Commits on Jul 4, 2024

  1. Configuration menu
    Copy the full SHA
    72c6cf1 View commit details
    Browse the repository at this point in the history
  2. [curate rename] refactor to match curate structure

    Includes changes to make the copied script work as a new Augur
    subcommand and fit in with the codebase. The functional behaviour of the
    actual renaming is unchanged, although the I/O options are now expanded
    as we inherit the general `augur curate` machinery.
    jameshadfield committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    fb54c4c View commit details
    Browse the repository at this point in the history
  3. [curate rename] Add tests

    Tests describe desired output, not current output
    jameshadfield committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    c2b2297 View commit details
    Browse the repository at this point in the history
  4. [curate rename] update behaviour

    to match expected behaviour in tests.
    
    The main changes functional changes are around the order of fields,
    where we now rename "in-place" rather than adding the renamed column
    at the end (which for TSV output is the last column).
    
    More sanity checks are performed on arguments and they are
    cross-referenced with the provided records.
    
    Note that this relies on each record having the same fields, and this is
    not asserted here. See <#1510>
    jameshadfield committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    84ee0af View commit details
    Browse the repository at this point in the history
  5. [curate rename] allow column duplication

    See discussion in PR review for context
    <#1506 (comment)>
    jameshadfield committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    8c3ac16 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. changelog

    jameshadfield committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    0d0401b View commit details
    Browse the repository at this point in the history