Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: Support sequences with cross-checking #1601

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Aug 27, 2024

Description of proposed changes

Initial prototype for sequence support in augur merge where metadata and sequence merge happens with additional cross-checking.

Related issue(s)

Closes #1579

Checklist

  • Address FIXMEs
  • Add seqkit as an external dependency (c099e16)
  • Automated checks pass
  • Check if you need to add a changelog message
  • Check if you need to add tests
  • Check if you need to update docs

@victorlin victorlin self-assigned this Aug 27, 2024
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 59.37500% with 13 lines in your changes missing coverage. Please review.

Project coverage is 70.99%. Comparing base (da1c89d) to head (d143872).

Files Patch % Lines
augur/merge.py 59.37% 7 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1601      +/-   ##
==========================================
- Coverage   71.02%   70.99%   -0.03%     
==========================================
  Files          79       79              
  Lines        8256     8286      +30     
  Branches     2003     2013      +10     
==========================================
+ Hits         5864     5883      +19     
- Misses       2101     2107       +6     
- Partials      291      296       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@victorlin victorlin changed the title merge: Add --sequences + --output-sequences merge: Add --sequences + --output-sequences with cross-checking Sep 16, 2024
@victorlin victorlin changed the title merge: Add --sequences + --output-sequences with cross-checking merge: Support sequences with cross-checking Sep 16, 2024
Preparing for use across functions.
Preparing for use across functions.
Preparing for use across functions.
Preparing for NamedSequences
Sequence support requires the ability to load metadata into the database
without actually merging (if --output-metadata is not specified).
Preparing for sequence support.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

merge: Support sequences
1 participant