Properly upload coverage file with upload-artifact v4.4.0

[victorlin]

Description of proposed changes

v4.4.0 introduces a breaking change which prevents hidden files from being uploaded, which includes the standard .coverage filename. The coverage file could be easily renamed, but it's also easy to keep the existing name and upload the hidden file explicitly.

Related issue(s)

Closes #1616

Checklist

• Codecov artifact upload/download is working in CI
• Check if you need to add a changelog message
• Check if you need to add tests
• Check if you need to update docs

[corneliusroemer]

Gee, I was wondering whether it was something in the action. Should we pin it at minor version then (if that's at all possible)?

A link to the breaking change/issue in upstream repo would be nice 🙃

Update: wow people are angry about this - it broke so many people's workflows.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.03%. Comparing base (ade798b) to head (a5a2628).
Report is 9 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1618      +/-   ##
==========================================
- Coverage   71.06%   71.03%   -0.04%     
==========================================
  Files          79       79              
  Lines        8267     8258       -9     
  Branches     2007     2005       -2     
==========================================
- Hits         5875     5866       -9     
  Misses       2101     2101              
  Partials      291      291              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[victorlin]

Should we pin it at minor version then (if that's at all possible)?

I don't see a reason to pin now, the damage is already done. Maybe something like >=v4.4.0 would be ideal but that's not possible.

A link to the breaking change/issue in upstream repo would be nice

I linked to our issue which links to the upstream issue, but I can see how that's hard to find. Thanks for adding the direct link.

Update: wow people are angry about this - it broke so many people's workflows.

Yeah for real, also released right before a long weekend in the US 😬
They did announce it ahead of time, but of course no one noticed the actual impact...

[corneliusroemer]

It doesn't matter whether they announced. One doesn't break on a minor version. There's 0 reason to. We can pin the exact sha. I feel like we should out of principle but I know they won't care. I don't think one can pin Gh actions like this >=4.4.0, you either do sha or tag as far as I remember.

I wasted some 10min on this yesterday, rerunning to see if it was just flaky. They could have at least posted some notification in the workflow summary, like the note "using outdated node" or something like that. Oh well, thanks for investigating and fixing!