Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if v5 export Using a v6 Translate File #392

Merged
merged 1 commit into from
Nov 7, 2019

Conversation

emmahodcroft
Copy link
Member

Address first part of issue #379 . Possibly less useful, as unlikely may people switch from v6 back to v5. Can take or leave this as we see fit.

Adds a check to export to look for v6-style translate files.

If the AA muts file seems to have been made with v6 augur translate (it has strand values of + or - rather than 0 or 1), then it will modify the provided start number and strand values to match the v5 format.

It also prints a warning to the user saying it looks like the file is from a newer augur version, that we've tried to convert it, but that we recommend them re-running translate and then running export again.

@jameshadfield
Copy link
Member

This will require a new release to v5 for people to get these changes right?

@emmahodcroft
Copy link
Member Author

Yes, it would. Which is maybe what makes it questionable? But it would make make sense, as it would protect against this mixing up of v5 and v6.

@jameshadfield jameshadfield added the v6 Issues relating to augur v6 / auspice v2 label Nov 5, 2019
@jameshadfield
Copy link
Member

Just updating this PR with some comments from slack -- there is an appetite for a further v5 release, which this should definitely be part of. (It's also desired to make augur export v1 synonymous with augur export in this v5 release.) I'm in favor of merging.

@jameshadfield jameshadfield removed the v6 Issues relating to augur v6 / auspice v2 label Nov 7, 2019
@trvrb
Copy link
Member

trvrb commented Nov 7, 2019

I'm in favor of merging. Thanks!

@jameshadfield jameshadfield merged commit ddb12d1 into master Nov 7, 2019
@jameshadfield jameshadfield deleted the v6_translate_warning branch November 7, 2019 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants