Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mugration weights #443

Merged
merged 11 commits into from
Feb 13, 2020
Merged

Mugration weights #443

merged 11 commits into from
Feb 13, 2020

Conversation

trvrb
Copy link
Member

@trvrb trvrb commented Feb 12, 2020

Include an option to set equilibrium frequencies to mugration analysis in augur traits. This passes in a --weights option that specifies a tsv or csv file in the following format:

division	Hubei	50.0
division	Jiangxi	1.0
division	Chongqing	1.0
...

where the first column refers to the metadata field name, the second to the trait and the third to its value. This mirrors the format we use for colors.tsv and lat_longs.tsv.

This can be tested with this branch of nCoV: https://github.com/nextstrain/ncov/tree/phylogeo

This needs to wait on merge of #431.

@trvrb trvrb mentioned this pull request Feb 12, 2020
@rneher
Copy link
Member

rneher commented Feb 12, 2020

The thing you changed in the last commit wasn't a typo. I had the weights file formated differently:

https://github.com/nextstrain/augur/blob/mugration_weights/tests/builds/zika/config/trait_weights.csv

we generally have to sort out how we deal with csv/tsv parsing. I think having a name in the first column is more natural. but I realize that we have it flipped in the colors file.

@trvrb
Copy link
Member Author

trvrb commented Feb 12, 2020

Ah! This makes more sense. I think I'd prefer to have this mirroring of colors.tsv and lat_longs.tsv with weights.tsv. Are you okay with this structure?

@trvrb trvrb merged commit 12c1720 into master Feb 13, 2020
@trvrb trvrb deleted the mugration_weights branch February 13, 2020 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants