Add unit test coverage of filter.write_vcf and refactor
#479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
reviewed
Mar 27, 2020
| #Read in/write out according to file ending | ||
| inCall = "--gzvcf" if compressed else "--vcf" | ||
| outCall = "| gzip -c" if output_file.lower().endswith('.gz') else "" | ||
| def write_vcf(input_filename, output_filename, dropped_samps): |
There was a problem hiding this comment.
Same concern as #478 about changing the API. If this is only used internally it is probably ok, but if they have any users this will cause code breakage.
|
@elebow LGTM! It looks like there are merge conflicts now with your earlier tests, but after you resolve these we can merge this PR. Thank you! |
elebow
force-pushed
the
filter-unit-test-coverage-write_vcf
branch
from
9b90a76
to
a31bcaf
Compare
Also introduce `pytest-mock` as a development dependency.
elebow
force-pushed
the
filter-unit-test-coverage-write_vcf
branch
from
a31bcaf
to
3097573
Compare
|
Rebased and resolved conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Akin to #478, adds unit test coverage and does some nonfunctional refactoring. There's more to do, but not until the module has better coverage.
This also introduces
pytest-mockas a development dependency.