Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pytest config with common options including coverage report #486

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Update pytest config with common options including coverage report #486

merged 1 commit into from
Mar 30, 2020

Conversation

willingc
Copy link
Contributor

@willingc willingc commented Mar 27, 2020 •
edited
Loading

This PR updates the pytest config file with common options:

  • add short traceback
  • display local variables for stacktrace
  • increase verbosity to display test names
  • add generation of html coverage report
  • git ignore the htmlcov directory since it doesn't need to be in version control

Related #476 #485

tacaswell
tacaswell approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That surfaces a bunch of concerning looking warnings....

@willingc willingc mentioned this pull request Mar 29, 2020
Merged
@huddlej
Copy link
Contributor

huddlej commented Mar 30, 2020

@willingc Looks good to me! Would you be able to rebase and merge these smaller commits into a single commit?

@huddlej huddlej merged commit 582492d into nextstrain:master Mar 30, 2020
@willingc willingc deleted the py3-review branch March 30, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@willingc @huddlej @tacaswell