Allow exception to bubble up when priority file is bad. #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elebow
force-pushed
the
allow-exceptions-from-bad-priority-file
branch
from
ded2d60
to
d44cc86
Compare
|
Might be worth still printing out the "ERROR: ..." next in case someone is screen-scraping the output? |
When the user specifies a priority file, the program should either obey the user's instructions or fail. A "best effort" approach with default values may result in the program doing something that the user did not intend. With "fail on error" behavior, user can have confidence that if the program completes, it followed the instructions as specified.
elebow
force-pushed
the
allow-exceptions-from-bad-priority-file
branch
from
d44cc86
to
f10e20a
Compare
|
@tacaswell good idea. I re-added |
tacaswell
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
In filter,
--priorityis an optional argument. When a user provides that argument, they are expressing an intent for the program to use those priorities in its calculations.If the specified file is missing or malformed, then the user's expressed intent cannot be carried out. The program should abort noisily, so the user can correct the problem or adjust their expressed intent.
The legacy behavior did print an
"ERROR:"message, but that's easy for the user to miss. It's more reliable to let the exception bubble up and abort execution.Related issue(s)
none
Testing
Unit tests included