Bump min ver for pandas to 1.0.0 #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
approved these changes
Mar 27, 2020
Zsailer
approved these changes
Apr 17, 2020
Codecov Report
@@ Coverage Diff @@
## master #488 +/- ##
=======================================
Coverage 19.16% 19.16%
=======================================
Files 31 31
Lines 5072 5072
Branches 1289 1289
=======================================
Hits 972 972
Misses 4077 4077
Partials 23 23 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
The goal of this PR is depend on at least pandas 1.0.0. Starting with 1.0.0, pandas adopted an official versioning scheme for guaranteeing compatibility (https://pandas.pydata.org/pandas-docs/stable/whatsnew/v1.0.0.html#new-deprecation-policy). This was a concern the last time pandas min ver was updated (#144)
Related issue(s)
Related to #144, #482 (pandas 1.0.0 only supports Python >=3.6.1)
Fixes: #483
Testing
The test suite passes. I inspected all the usages of pandas and saw, as mentioned in #144, that the primary use of pandas is
read_csv.Thank you for contributing to Nextstrain!