Support incomplete ambiguous dates #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #631 +/- ##
==========================================
+ Coverage 28.53% 28.68% +0.14%
==========================================
Files 39 39
Lines 5389 5389
Branches 1327 1326 -1
==========================================
+ Hits 1538 1546 +8
+ Misses 3793 3785 -8
Partials 58 58
Continue to review full report at Codecov.
|
Reverts logic in augur filter to not consider ambiguous date results and removes logic for tracking ambiguous dates from `get_numerical_dates`.
Updates the help documentation for the ambiguous date filter and uses the "not" operator instead of "is False" for readability of boolean expressions.
Expands the logic of the date ambiguity test function to support date strings like "YYYY" and "YYYY-MM" that caused the previous implementation to break. Since a date with only a year or year and month is stil valid, we mockup ambiguous day and month values for these incomplete date strings and explicitly test the resulting year, month, and day values. This commit also adds unit tests to represent these incomplete and ambiguous date strings.
huddlej
force-pushed
the
support-incomplete-ambiguous-dates
branch
from
9ee8661
to
3fd75d8
Compare
Cleans up unit tests for the `is_date_ambiguous` function, collecting them into a single function with clearer documentation. Also, adds tests for valid incomplete date strings and fixes a bug in the `is_date_ambiguous` function that was revealed by these new tests.
jameshadfield
requested changes
Nov 12, 2020
There was a problem hiding this comment.
Nice work @huddlej - another super useful addition to augur 👍
Replaces the "all" option for `is_date_ambiguous` with "any" and updates the help documentation, ambiguity boolean logic, and unit tests to clarify this hierarchical treatment of ambiguity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR continues work from #623 by adding support for incomplete ambiguous date strings like those matching the formats of "YYYY" and "YYYY-MM".
Related issue(s)
Related to #602.
Testing
Adds new unit tests for the case of incomplete ambiguous date strings.
Prior to merge
This PR should be rebased onto master after #623 is merged to avoid a messy git history.