Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump required treetime version to 0.8.0 #633

Merged
merged 4 commits into from
Nov 16, 2020
Merged

Conversation

rneher
Copy link
Member

@rneher rneher commented Nov 15, 2020

Description of proposed changes

not much has changed in treetime but I dropped python 2.7. So new middle digit.

Thank you for contributing to Nextstrain!

@codecov
Copy link

codecov bot commented Nov 15, 2020

Codecov Report

Merging #633 (6b9cc9c) into master (d2d5423) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #633   +/-   ##
=======================================
  Coverage   28.68%   28.68%           
=======================================
  Files          39       39           
  Lines        5389     5389           
  Branches     1326     1326           
=======================================
  Hits         1546     1546           
  Misses       3785     3785           
  Partials       58       58           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2d5423...6b9cc9c. Read the comment docs.

@huddlej huddlej added this to the Patch release 10.1.1 milestone Nov 16, 2020
@huddlej huddlej self-requested a review November 16, 2020 16:44
Copy link
Contributor

@huddlej huddlej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me. Thanks, @rneher!

Do you have an example of how to get the Nexus export error for BioPython? Can I just install TreeTime, force install the latest BioPython, and then run the TreeTime test suite?

@rneher
Copy link
Member Author

rneher commented Nov 16, 2020

I made an issue with an example:

biopython/biopython#3361

and also a PR that fixes it....

biopython/biopython#3366

@huddlej
Copy link
Contributor

huddlej commented Nov 16, 2020

Wow, that was fast! Thank you! Merging this now. I'll make a new Augur release with this change this morning.

@huddlej huddlej merged commit b153ecf into master Nov 16, 2020
@huddlej huddlej deleted the version_bump_treetime branch November 16, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants