Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include LICENSE.txt in distribution artifacts with MANIFEST.in not data_files #678

Merged
merged 1 commit into from
Feb 13, 2021

Conversation

tsibley
Copy link
Member

@tsibley tsibley commented Feb 12, 2021

data_files are installed immediately under the Python installation root
(sys.prefix), e.g. /usr/local or ~/.conda/envs/…/, which is just rude.
It's also causing permission issues that otherwise wouldn't happen on
the macOS CI I'm setting up for Nextstrain CLI.

…ta_files

data_files are installed immediately under the Python installation root
(sys.prefix), e.g. /usr/local or ~/.conda/envs/…/, which is just rude.
It's also causing permission issues that otherwise wouldn't happen on
the macOS CI I'm setting up for Nextstrain CLI.
@tsibley tsibley requested a review from huddlej February 12, 2021 23:00
Copy link
Contributor

@huddlej huddlej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@huddlej huddlej merged commit de4cf97 into master Feb 13, 2021
@huddlej huddlej deleted the license-inclusion branch February 13, 2021 00:41
@huddlej huddlej added this to the Patch release 11.1.1 milestone Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants