Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure parsing in augur export v2 #752

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Conversation

benjaminotter
Copy link
Contributor

Description of proposed changes

Restructures the parsing of metadata and node data files in augur export_v2. The metadata and node data files are now loaded prior to calling the parser. The load calls are wrapped in two individual try/except blocks in order to print a specific error message if any of the files are missing.
The parser was modified to now take the already loaded files as input instead of loading the files itself.
Still need to check whether the parser function is referenced outside of the export module.

Related issue(s)

Fixes #733

Testing

no further doctests added
tested with the nextstrain Zika tutorial

…catch missing file errors. Modifies the parser to take loaded files as input
@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #752 (967896a) into master (653079e) will decrease coverage by 0.02%.
The diff coverage is 8.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #752      +/-   ##
==========================================
- Coverage   31.52%   31.50%   -0.03%     
==========================================
  Files          41       41              
  Lines        5754     5758       +4     
  Branches     1389     1389              
==========================================
  Hits         1814     1814              
- Misses       3865     3869       +4     
  Partials       75       75              
Impacted Files Coverage Δ
augur/export_v2.py 11.00% <8.33%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 653079e...967896a. Read the comment docs.

Copy link
Contributor

@huddlej huddlej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked for me! Thank you, @benjaminotter!

@huddlej huddlej marked this pull request as ready for review July 27, 2021 04:01
@huddlej huddlej added this to the Feature release 13.0.0 milestone Jul 27, 2021
@huddlej huddlej merged commit f55bc83 into master Jul 27, 2021
@huddlej huddlej deleted the export-fix-missing-metadata branch July 27, 2021 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

augur export v2: meta data file does not exist
2 participants