feat: add Reunion to lat/longs #791
Conversation
|
Reunion is a territory of France - need to ensure ingest is correctly
assigning this. We've discussed different ways to address overseas
territories previously, but this is how we've handled them this far.
…On Tue, 30 Nov 2021, 01:19 Cornelius Roemer, ***@***.***> wrote:
------------------------------
You can view, comment on, or merge this pull request online at:
#791
Commit Summary
- c45ec7f
<c45ec7f>
feat: add Reunion to lat/longs
File Changes
(1 file <https://github.com/nextstrain/augur/pull/791/files>)
- *M* augur/data/lat_longs.tsv
<https://github.com/nextstrain/augur/pull/791/files#diff-e3985a516ac8b01030fa72ee8baafb26a61c792eb8c54cc8c985de8694624104>
(1)
Patch Links:
- https://github.com/nextstrain/augur/pull/791.patch
- https://github.com/nextstrain/augur/pull/791.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#791>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADNA54Q6GOSJ3MKSIPIICETUOQKCJANCNFSM5JANUUPA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
There was a problem hiding this comment.
I can't remember our thinking about whether to include lat-longs for territories (and similar political classifications), but I think it's sensible for strains from Reunion to be shown in Reunion, in my opinion. I'll also note we have country lat-longs for American Samoa, British Virgin Islands etc.
augur/data/lat_longs.tsv
Outdated
| @@ -187,6 +187,7 @@ country portugal 39.6945 -8.13057 | |||
| country puerto_rico 18.2459121 -66.4164147 | |||
| country puerto rico 18.2459121 -66.4164147 | |||
| country qatar 25.27932 51.52245 | |||
| country reunion -21.1151 55.5364 | |||
There was a problem hiding this comment.
Needs to change to tabs not spaces (at least, https://raw.githubusercontent.com/nextstrain/augur/c45ec7f828b3575f07a2caee67b833fc05a0666d/augur/data/lat_longs.tsv appears to be using spaces not tabs)
There was a problem hiding this comment.
oops yes!
and I agree, not much point showing reunion sequences in France just because of politics...
|
Reunion is classified as a country by GISAID, I use the GISAID augur export directly, which is how I noticed |
|
P.S. We have specific GISAID annotation rules which change the country to France for Reunion sequences, so adding this lat-long won't change builds provisioned from that data. |
No description provided.