Remove upper bounds on dependency versions #821
Conversation
|
Ah, I misunderstood your original suggestion in Slack, I think, @victorlin. The dev dependencies don't need to be pinned, but we do want to keep the main deps and the "extra" deps pinned at major version numbers. Even though the Python docs say this is not a best practice, Python's own packaging "best practices" are not consistently followed and we have good reason not to follow this guideline. In our case, we want to protect against unexpectedly using Pandas 2.0, for example, when we haven't fully tested it. The dev dependencies are less critical, since so few people use them and they don't need to be as conservatively pinned anyway. Would you mind reverting just the major version pins here for the main and extra deps? |
Although we recently relaxed version pinning for development dependencies [1], we still need to maintain major version limits for base and full requirements to prevent unexpected issues when those dependencies release new major versions. For example, a new major pandas version has a potential to produce breaking changes. [1] #821
|
@huddlej sorry, your comment got lost in my sea of GitHub notifications. Thanks for taking care of it! |
From Python Packaging User Guide:
Most of these pins were added a couple years ago and there are now newer versions. For example
pytest>=6.2.5is required for Python 3.10 due to pytest-dev/pytest#8540.Keeping the lower bounds in case of minimum version support that I might be unaware of.
Merging without approval given passing tests.