-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update supported Python versions to drop 3.6, include 3.9 and 3.10 #822
Conversation
Codecov Report
@@ Coverage Diff @@
## master #822 +/- ##
==========================================
+ Coverage 33.81% 33.83% +0.01%
==========================================
Files 41 41
Lines 5905 5905
Branches 1466 1507 +41
==========================================
+ Hits 1997 1998 +1
+ Misses 3825 3824 -1
Partials 83 83
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! We will also need to make a separate PR for the Bioconda recipe to update the minimum Python versions for host and run.
I like the idea of using a BioPython matrix (in a separate PR) instead of hardcoding a specific, for the reasons @tsibley lists in the discussion you linked to. The main issue being that we could have passing tests for the old version of BioPython but failing tests for newer versions.
As noted in the since_augur_version
variable in setup.py
, we will need a major release for this PR. Since #839 may also introduce a breaking change to the UI for augur tree, we might release these both at the same time in 14.0.0.
At what stage in the release process should this happen? I assume it would be best to somehow link this to the auto-bump PR once we push the new version to pip, but we would have to be diligent to catch it before a maintainer merges. Or do they have a more manual process for major version changes? |
Nevermind, I see you answered my question a couple months ago in #793. I'll plan to open a draft PR in bioconda, then link it to the auto-bump PR once that happens. Shouldn't be difficult to catch it before they merge. |
Description of proposed changes
This PR updates supported Python versions based on current EOL status.
Note: I didn't update minimum version for biopython, since I'm not sure what we want to support. I'm thinking we bump from 1.67 to 1.73 like 3dd5160 (not in PR), would that be reasonable? We could also try a
matrix
based on this discussion.Related issue(s)