Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported Python versions to drop 3.6, include 3.9 and 3.10 #822

Merged
merged 4 commits into from
Feb 2, 2022

Conversation

victorlin
Copy link
Member

Description of proposed changes

This PR updates supported Python versions based on current EOL status.

  • Add variable for Augur version associated with min Python version: 3f09747
  • Update CI matrix and minimum version references: 65c736f
  • Bump Augur version associated with min Python version to 14: 6451394

Note: I didn't update minimum version for biopython, since I'm not sure what we want to support. I'm thinking we bump from 1.67 to 1.73 like 3dd5160 (not in PR), would that be reasonable? We could also try a matrix based on this discussion.

Related issue(s)

@victorlin victorlin self-assigned this Dec 30, 2021
@codecov
Copy link

codecov bot commented Dec 30, 2021

Codecov Report

Merging #822 (fc5b396) into master (058372d) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #822      +/-   ##
==========================================
+ Coverage   33.81%   33.83%   +0.01%     
==========================================
  Files          41       41              
  Lines        5905     5905              
  Branches     1466     1507      +41     
==========================================
+ Hits         1997     1998       +1     
+ Misses       3825     3824       -1     
  Partials       83       83              
Impacted Files Coverage Δ
augur/import_beast.py 7.14% <0.00%> (+0.02%) ⬆️
augur/export_v2.py 11.00% <0.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 058372d...fc5b396. Read the comment docs.

Copy link
Contributor

@huddlej huddlej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We will also need to make a separate PR for the Bioconda recipe to update the minimum Python versions for host and run.

I like the idea of using a BioPython matrix (in a separate PR) instead of hardcoding a specific, for the reasons @tsibley lists in the discussion you linked to. The main issue being that we could have passing tests for the old version of BioPython but failing tests for newer versions.

As noted in the since_augur_version variable in setup.py, we will need a major release for this PR. Since #839 may also introduce a breaking change to the UI for augur tree, we might release these both at the same time in 14.0.0.

@victorlin victorlin merged commit a85194c into master Feb 2, 2022
@victorlin victorlin deleted the victorlin/update-python-versions branch February 2, 2022 18:01
@victorlin victorlin added this to the Major release 14.0.0 milestone Feb 2, 2022
@victorlin
Copy link
Member Author

@huddlej

We will also need to make a separate PR for the Bioconda recipe to update the minimum Python versions

At what stage in the release process should this happen? I assume it would be best to somehow link this to the auto-bump PR once we push the new version to pip, but we would have to be diligent to catch it before a maintainer merges. Or do they have a more manual process for major version changes?

@victorlin
Copy link
Member Author

Nevermind, I see you answered my question a couple months ago in #793. I'll plan to open a draft PR in bioconda, then link it to the auto-bump PR once that happens. Shouldn't be difficult to catch it before they merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants